Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ARIA 1.1 attributes and roles #1436

Merged
merged 1 commit into from
May 10, 2018
Merged

Add new ARIA 1.1 attributes and roles #1436

merged 1 commit into from
May 10, 2018

Conversation

maxmilton
Copy link
Contributor

This PR adds the new ARIA attributes and roles as defined in https://www.w3.org/TR/wai-aria-1.1/.

I found which attr/roles had changed via:

Originally I just wanted to use the new aria-role=switch in one of my components but as it turns out there's a bunch of new additions worth adding.

@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #1436 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1436   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         122      122           
  Lines        4491     4491           
  Branches     1406     1406           
=======================================
  Hits         4091     4091           
  Misses        158      158           
  Partials      242      242
Impacted Files Coverage Δ
src/validate/html/a11y.ts 91.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7fd1d...37fa4fb. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 05f7d44 into sveltejs:master May 10, 2018
@Rich-Harris
Copy link
Member

thank you!

@maxmilton maxmilton deleted the feat/wai-aria-1.1-update branch May 11, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants