-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: turn reactive_declaration_non_reactive_property
into a runtime warning
#14192
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2207b7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14192-svelte.vercel.app/ this is an automated message |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I commented on that other PR I think this approach makes more sense, so 👍
Co-authored-by: Simon H <[email protected]>
Co-authored-by: Simon H <[email protected]>
I agree this approach makes sense |
Alternative to #14111. Instead of a compiler warning, we can have a runtime warning for cases where 'invisible' reactive state is read inside a
$:
statement. The message could probably be improved and it might be nice to have a detailed example for the docs, but putting this up just as a suggestion for nowBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint