Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim whitespace while migrating blocks #13941

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Oct 25, 2024

Before submitting the PR, please make sure you do the following

This kinda closes #13933...since now having no whitespace before the blocks is enforced by svelte let's trim everything while migrating.

Edit this will also close #13483 (we can't really fix the inconsistencies without a breaking change unfortunately)

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 56f78fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 25, 2024

pnpm add https://pkg.pr.new/svelte@13941

commit: 56f78fc

@trueadm
Copy link
Contributor

trueadm commented Oct 25, 2024

Why does it "kinda close", what's missing?

@paoloricciuti
Copy link
Member Author

Why does it "kinda close", what's missing?

It can be closed, is just not the thing they asked for 😄

@paoloricciuti paoloricciuti merged commit 12fcc7a into main Oct 26, 2024
10 checks passed
@paoloricciuti paoloricciuti deleted the migrate-whitespace-blocks branch October 26, 2024 16:20
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants