Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Rapidly toggling element with out: transition causes incorrect node removal #13884

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Oct 24, 2024

Fix #13681

On some rare case when a out transition is quickly canceled, the "dummy transition" onfinish can be executed after the cancel, and the node will be removed from the DOM.

It seems that setting onfinish back to noop fixes the problem.
However the bug is not systematic (the joys of race conditions), and I can't come up with a proper test for this.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 10af118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have been doing this anyway, thank you.

@trueadm trueadm merged commit d017771 into sveltejs:main Oct 24, 2024
7 checks passed
dummdidumm pushed a commit that referenced this pull request Oct 24, 2024
@adiguba
Copy link
Contributor Author

adiguba commented Oct 25, 2024

Sorry I forgot the changeset :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rapidly toggling element with out: transition causes incorrect node removal
2 participants