Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve outer context for await blocks #1379

Merged
merged 1 commit into from
Apr 29, 2018
Merged

preserve outer context for await blocks #1379

merged 1 commit into from
Apr 29, 2018

Conversation

Rich-Harris
Copy link
Member

fixes #1251

@codecov-io
Copy link

codecov-io commented Apr 29, 2018

Codecov Report

Merging #1379 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1379      +/-   ##
==========================================
+ Coverage   91.11%   91.11%   +<.01%     
==========================================
  Files         120      120              
  Lines        4421     4422       +1     
  Branches     1360     1360              
==========================================
+ Hits         4028     4029       +1     
  Misses        156      156              
  Partials      237      237
Impacted Files Coverage Δ
src/compile/nodes/AwaitBlock.ts 93.58% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed605bf...5fd4965. Read the comment docs.

@Rich-Harris Rich-Harris merged commit d8ca0e3 into master Apr 29, 2018
@Rich-Harris Rich-Harris deleted the gh-1251 branch April 29, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

await loses access to outer each variable
2 participants