Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better children snippet / default slot interop #13734

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

dummdidumm
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- correctly assign children snippet to default slot, fixes #13067
- allow `svelte:fragment` without `let:` directives to be rendered by `@render children()`, fixes #13066
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 52051b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member Author

Self-merging because this is rather critical

@dummdidumm dummdidumm merged commit 8251bae into main Oct 21, 2024
9 checks passed
@dummdidumm dummdidumm deleted the snippet-slot-interop-fix branch October 21, 2024 08:33
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
@hmnd
Copy link

hmnd commented Oct 21, 2024

Thank you so much! Appreciate the quick turnaround.

@brunnerh
Copy link
Member

brunnerh commented Oct 21, 2024

@dummdidumm Can named slots be made to work as well?
REPL showing all kinds of snippet/slot combinations

@benmccann
Copy link
Member

@brunnerh thanks for testing the various combos. Could you file a new issue for that?

@brunnerh
Copy link
Member

@benmccann There would already be #13063 which was (probably prematurely) marked as documentation.

@brunnerh
Copy link
Member

Added #13784 for better visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippets and slots interop Invalid parent uses let: error when parent doesn't use let:
4 participants