-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 #1348
Merged
Merged
v2 #1348
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
470eacf
remove obsolete methods
Rich-Harris 34d2fbf
remove ES5 constraint
Rich-Harris 7b40fed
remove unused store methods
Rich-Harris 9070969
remove references to obsolete methods
Rich-Harris 9bc8b74
update store tests
Rich-Harris daa2635
update snapshot tests
Rich-Harris 2f86bd3
update tests to account for removal of observe
Rich-Harris df4e367
update snapshot tests
Rich-Harris a3add04
remove code, map and cssMap from svelte.compile output
Rich-Harris 80e0dce
remove validate and Stylesheet from public API
Rich-Harris 4fe8d95
dont typecast numeric attributes
Rich-Harris 21168bf
remove v1 parser tests
Rich-Harris 286caba
oops
Rich-Harris ab79cc6
remove v1 snapshot tests
Rich-Harris ce11460
remove deprecated renderCss method
Rich-Harris 4b3da75
remove v1 runtime tests
Rich-Harris 1143b0a
remove v1 tests
Rich-Harris 2d5b47b
remove store option
Rich-Harris 39ad124
update validation tests
Rich-Harris 8eb4adc
small fix
Rich-Harris a275960
SSR tests
Rich-Harris 39d0b86
update hydration tests
Rich-Harris 40e6b4f
update css tests
Rich-Harris 87a8e37
remove cascade option
Rich-Harris cae4dd9
fix some more tests
Rich-Harris 73e83e5
tidy up
Rich-Harris dadf21c
skip test, fix post-v2
Rich-Harris d2a5b36
remove redundant test
Rich-Harris a32c2ba
Merge branch 'master' into v2
Rich-Harris 7e733d8
enforce uppercase component names
Rich-Harris b9fcc16
update test
Rich-Harris 07bad96
tidy up
Rich-Harris 5a457bf
rename loc to start, include character info in locations
Rich-Harris 69c41a0
use new Function instead of eval, to prevent Rollup complaining
Rich-Harris a2d3d05
merge master -> v2
Rich-Harris da6fa85
update README
Rich-Harris 1e9b32a
fixes
Rich-Harris f2b6ec4
fix <svelte:window> to use new APIs
Conduitry 06517ce
remove erroneous warnings
Rich-Harris fb9d7cd
remove obsolete hash stuff
Rich-Harris 6ff02b2
remove legacy prop stuff, now that we emit ES2015
Rich-Harris aaab685
support $method(...) calls, and warn on store.method(...)
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<button use:foo>{{x}}</button> | ||
<button use:foo>{x}</button> | ||
|
||
<script> | ||
export default { | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<textarea readonly="{{false}}"></textarea> | ||
<textarea readonly="{false}"></textarea> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<input type='checkbox' indeterminate='{{indeterminate}}'> | ||
<input type='checkbox' indeterminate='{indeterminate}'> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<textarea readonly="{{true}}"></textarea> | ||
<textarea readonly="{true}"></textarea> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{{#each items as item, i}} | ||
<div class='{{item.foo ? "foo" : ""}} {{item.bar ? "bar" : ""}}'>{{i + 1}}</div> | ||
{{/each}} | ||
{#each items as item, i} | ||
<div class='{item.foo ? "foo" : ""} {item.bar ? "bar" : ""}'>{i + 1}</div> | ||
{/each} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<span title='{{"\"foo\""}}'>foo</span> | ||
<span title='{"\"foo\""}'>foo</span> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<div class='{{class}}'></div>{{123}} | ||
<div class='{class}'></div>{123} |
9 changes: 0 additions & 9 deletions
9
test/runtime/samples/attribute-dynamic-shorthand/main-v2.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<div :id/> | ||
<div {id}/> | ||
|
||
<script> | ||
export default { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<input type='{{inputType}}' value='{{inputValue}}'> | ||
<input type='{inputType}' value='{inputValue}'> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<svg> | ||
<use xlink:href="#{{foo}}"/> | ||
<use xlink:href="#{foo}"/> | ||
</svg> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<p data-value="{{value}}"></p> | ||
<p data-value="{value}"></p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
<input type='radio' bind:group='foo' value='{{false}}'> | ||
<input type='radio' bind:group='foo' value='{{true}}'> | ||
<input type='radio' bind:group='foo' value='{false}'> | ||
<input type='radio' bind:group='foo' value='{true}'> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{{#if visible}} | ||
{#if visible} | ||
<input ref:input autofocus> | ||
{{/if}} | ||
{/if} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<p>{{value}}</p> | ||
<p>{{called}}</p> | ||
<p>{value}</p> | ||
<p>{called}</p> | ||
|
||
<script> | ||
export default { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{{#if promise}} | ||
{{#await promise}} | ||
{#if promise} | ||
{#await promise} | ||
<p>wait for it...</p> | ||
{{then _}} | ||
<p>the answer is {{answer}}!</p> | ||
{{catch error}} | ||
{:then _} | ||
<p>the answer is {answer}!</p> | ||
{:catch error} | ||
<p>well that's odd</p> | ||
{{/await}} | ||
{{/if}} | ||
{/await} | ||
{/if} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
<div> | ||
{{#await thePromise}} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
<p>the value is {{theValue}}</p> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{:then theValue} | ||
<p>the value is {theValue}</p> | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{{#await thePromise}} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
{:then theValue} | ||
<button ref:button on:click='set({ clicked: theValue })'>click me</button> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{{#if show}} | ||
{{#await thePromise}} | ||
{#if show} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
<p>the value is {{theValue}}</p> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{{else}} | ||
{:then theValue} | ||
<p>the value is {theValue}</p> | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} | ||
{:else} | ||
<p>Else</p> | ||
{{/if}} | ||
{/if} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
{{#await thePromise}} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
<p>the value is {{theValue}}</p> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{:then theValue} | ||
<p>the value is {theValue}</p> | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} | ||
|
||
{{#await thePromise}} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
<p>the value is {{theValue}}</p> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{:then theValue} | ||
<p>the value is {theValue}</p> | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} |
12 changes: 6 additions & 6 deletions
12
test/runtime/samples/await-then-catch-non-promise/main.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{{#await thePromise}} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
<p>the value is {{theValue}}</p> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{:then theValue} | ||
<p>the value is {theValue}</p> | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{{#await thePromise}} | ||
{#await thePromise} | ||
<p>loading...</p> | ||
{{then theValue}} | ||
<p>the value is {{theValue}}</p> | ||
{{catch theError}} | ||
<p>oh no! {{theError.message}}</p> | ||
{{/await}} | ||
{:then theValue} | ||
<p>the value is {theValue}</p> | ||
{:catch theError} | ||
<p>oh no! {theError.message}</p> | ||
{/await} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D: D:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh