Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly migrate $$slots with bracket member expressions & slots with static props #13468

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Oct 1, 2024

Svelte 5 rewrite

Closes #13467 (i've also fixed a bug regarding the migration of $$slots when the component is a custom element.

EDIT: it was simple enough so i also fixed #13466

EDIT to the EDIT: i also fixed #13472 in this PR...since it was not reviewed yet i just pushed here, if you need a clearer vision while reviewing you can just look at the separate commits since they are pretty much self contained.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 9fa1626

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti changed the title fix: correctly migrate $$slots with bracket member expressions fix: correctly migrate $$slots with bracket member expressions & slots with static props Oct 1, 2024
@dummdidumm dummdidumm merged commit 49a0908 into main Oct 4, 2024
9 checks passed
@dummdidumm dummdidumm deleted the fix-slots-with-bracket-notation branch October 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants