Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codes to warnings #1340

Merged
merged 4 commits into from
Apr 15, 2018
Merged

add codes to warnings #1340

merged 4 commits into from
Apr 15, 2018

Conversation

Rich-Harris
Copy link
Member

fixes #474. Realised this isn't actually a breaking change so isn't a prerequisite for v2, but is a good thing to get done nonetheless. Only warnings so far, need to do errors as well.

@codecov-io
Copy link

codecov-io commented Apr 15, 2018

Codecov Report

Merging #1340 into master will increase coverage by 0.02%.
The diff coverage is 79.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
+ Coverage   91.72%   91.74%   +0.02%     
==========================================
  Files         125      125              
  Lines        4505     4509       +4     
  Branches     1430     1431       +1     
==========================================
+ Hits         4132     4137       +5     
  Misses        149      149              
+ Partials      224      223       -1
Impacted Files Coverage Δ
src/css/Stylesheet.ts 90.62% <ø> (ø) ⬆️
test/parser/index.js 100% <ø> (ø) ⬆️
src/generators/wrapModule.ts 91.02% <ø> (ø) ⬆️
src/validate/js/utils/checkForComputedKeys.ts 33.33% <0%> (ø) ⬆️
src/validate/html/validateHead.ts 60% <0%> (ø) ⬆️
src/validate/js/propValidators/immutable.ts 0% <0%> (ø) ⬆️
src/parse/state/mustache.ts 89.41% <0%> (ø) ⬆️
src/validate/js/propValidators/actions.ts 50% <0%> (ø) ⬆️
src/validate/js/propValidators/setup.ts 50% <0%> (ø) ⬆️
src/validate/html/index.ts 97.87% <100%> (ø) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4b166...35f4a1f. Read the comment docs.

@Rich-Harris Rich-Harris changed the title [WIP] add codes to warnings add codes to warnings Apr 15, 2018
@Rich-Harris
Copy link
Member Author

This was fantastically tedious. I hope it proves useful to someone someday.

@Rich-Harris Rich-Harris merged commit 7fe139f into master Apr 15, 2018
@Rich-Harris Rich-Harris deleted the gh-474 branch April 15, 2018 15:24
Rich-Harris added a commit that referenced this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codes and URLs to errors/warnings
2 participants