Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement syntax changes #1330

Merged
merged 15 commits into from
Apr 14, 2018
Merged

implement syntax changes #1330

merged 15 commits into from
Apr 14, 2018

Conversation

Rich-Harris
Copy link
Member

This duplicates all the parser tests with a -v2 suffix, and enables opting in to the new syntax with the parser: 'v2' compiler option. When it comes time for v2, we can just remove all the old stuff.

@Rich-Harris Rich-Harris mentioned this pull request Apr 11, 2018
@codecov-io
Copy link

codecov-io commented Apr 11, 2018

Codecov Report

Merging #1330 into master will decrease coverage by <.01%.
The diff coverage is 90.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         125      125              
  Lines        4472     4505      +33     
  Branches     1401     1430      +29     
==========================================
+ Hits         4102     4132      +30     
- Misses        146      149       +3     
  Partials      224      224
Impacted Files Coverage Δ
src/validate/html/index.ts 97.87% <ø> (ø) ⬆️
test/parser/index.js 100% <ø> (ø) ⬆️
...rators/server-side-rendering/visitors/Component.ts 96.77% <100%> (ø) ⬆️
src/parse/state/text.ts 100% <100%> (ø) ⬆️
src/parse/read/expression.ts 100% <100%> (ø) ⬆️
src/generators/nodes/Component.ts 96.9% <100%> (ø) ⬆️
src/parse/state/fragment.ts 100% <100%> (ø) ⬆️
src/generators/Generator.ts 96.68% <100%> (ø) ⬆️
src/utils/createDebuggingComment.ts 100% <100%> (ø) ⬆️
src/generators/nodes/EachBlock.ts 97.63% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebe535...2b3fe0e. Read the comment docs.

@Rich-Harris
Copy link
Member Author

Made a tiny bit more progress. I've also built a tool for automatically updating your components, which we can use to thoroughly test this all out prior to release:

https://github.com/sveltejs/svelte-upgrade

@Rich-Harris Rich-Harris changed the title [WIP] implement syntax changes implement syntax changes Apr 14, 2018
@Rich-Harris
Copy link
Member Author

I think everything is accounted for now. This effectively pulls the trigger on v2 — it will be costly to make further changes while both syntaxes are supported, so in a bit I'll put together a TODO list of what else needs to happen for v2. There's a GitHub project for it, but it's currently incomplete.

@Rich-Harris Rich-Harris merged commit 813e077 into master Apr 14, 2018
@Rich-Harris Rich-Harris deleted the gh-1318 branch April 14, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants