-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement syntax changes #1330
implement syntax changes #1330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 125 125
Lines 4472 4505 +33
Branches 1401 1430 +29
==========================================
+ Hits 4102 4132 +30
- Misses 146 149 +3
Partials 224 224
Continue to review full report at Codecov.
|
Made a tiny bit more progress. I've also built a tool for automatically updating your components, which we can use to thoroughly test this all out prior to release: |
I think everything is accounted for now. This effectively pulls the trigger on v2 — it will be costly to make further changes while both syntaxes are supported, so in a bit I'll put together a TODO list of what else needs to happen for v2. There's a GitHub project for it, but it's currently incomplete. |
This duplicates all the parser tests with a
-v2
suffix, and enables opting in to the new syntax with theparser: 'v2'
compiler option. When it comes time for v2, we can just remove all the old stuff.