Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on duplicate style and class directive #13097

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Sep 1, 2024

Svelte 5 rewrite

Closes #13095

I've also left a comment about the rest of the directives since i fell in the trap of try to add those tho only to discover they were already handled.

UPDATE: linting fortunately caught something i didn't realised could've been a problem. Something like this

<div draggable={true} class:draggable={true} />

Should actually be allowed, so i've fixed this bug...i've slightly modified the test runner to assert that a code should not produce compiler errors so that i was able to also test for this. Let me know if it's not what we want, i can move the test in another suite but it seemed something that could be useful. scratch that, after a chat with Simon i moved the test to validator and reverted the changes.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 1, 2024

🦋 Changeset detected

Latest commit: 49b97ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 0d51474 into sveltejs:main Sep 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Svelte 5] No more "Attributes need to be unique" error on duplicate class:name and style:property directives
2 participants