chore: set binding.kind before analysis
#12843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30edaf3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It actually turns out this isn't necessary for #12824 — that was a misdiagnosis, now fixed. I still think this is worth doing though. |
trueadm
approved these changes
Aug 14, 2024
Rich-Harris
pushed a commit
that referenced
this pull request
Aug 17, 2024
* chore: inline start and end node properties into effect * Revert "chore: set `binding.kind` before analysis (#12843)" This reverts commit 19beb77. * name better * oops * revert * revert * revert --------- Co-authored-by: Conduitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for #12824. This sets
binding.kindfor all bindings before we walk the AST in the analysis phase, but only in legacy mode.(In runes mode it's more awkward because declarations can be anywhere, and we can't set
kindat the declaration site until we know definitively whether we're in runes mode or not. When we get rid of legacy mode, this restriction will go away. In the meantime, it doesn't matter for #12824, because it's about$:statements which are only valid in legacy mode.)Doing it this way means we can provide better warnings during the analysis phase.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint