fix: provide more hydration mismatch coverage #12755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c30f53d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Added a test and tweaked some of the logic a bit. There is another case that this doesn't cover — it's possible for things to get out of whack in a component that doesn't call |
5 tasks
|
Actually I think we should move the second failing test into a separate PR, since there's no sense in holding up a fix for the more common case. Opened #12791 |
Rich-Harris
approved these changes
Aug 10, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12737. I can't come up with a test because I don't know how to spoof iOS being wacky and transforming the HTML. However, I did test this fix against the issue with iOS changing the phone number on Safari iOS and can confirm it works – we provide the warning and also repair the DOM.