Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up dynamic event handler generated code #12553

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

Rich-Harris
Copy link
Member

Small tweak post-#12549 — we can make dynamic event handlers a bit more compact:

button.__click = function (...$$args) {
- const $$callback = a || b;
-
- return $$callback?.apply(this, $$args);
+ return (a || b)?.apply(this, $$args);
};

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 8a29715

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brunnerh
Copy link
Member

Please also see #12520 (comment)

@Rich-Harris
Copy link
Member Author

This is orthogonal to that issue

@brunnerh
Copy link
Member

Mainly wanted to preempt potential conflicts in case Dominic did some follow-up changes in response to my comment. Excuse my meddling 😅

@Rich-Harris
Copy link
Member Author

All good — I wasn't aware of that side issue until you flagged it

@trueadm trueadm merged commit 7b2279d into main Jul 23, 2024
9 checks passed
@trueadm trueadm deleted the tidy-up-dynamic-handlers branch July 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants