Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydrate multiple <svelte:head> elements correctly #12475

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 17, 2024

The head hydration anchor didn't update after hydrating the contents of one <svelte:head> element, which meant subsequent <svelte:head> elements would always start at the beginning of the head. This PR fixes that. The test was updated such that the shape of each <svelte:head> content is sufficiently different to throw an error if this wasn't fixed.

fixes #12458
fixes #12399

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The head hydration anchor didn't update after hydrating the contents of one `<svelte:head>` element, which meant subsequent `<svelte:head>` elements would always start at the beginning of the head. This PR fixes that. The test was updated such that the shape of each `<svelte:head>` content is sufficiently different to throw an error if this wasn't fixed.

fixes #12458
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: a92e715

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit bc9907a into main Jul 17, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the head-hydration branch July 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants