allow SVG elements to have scoped CSS #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
+ Coverage 91.67% 91.67% +<.01%
==========================================
Files 126 126
Lines 4575 4576 +1
Branches 1501 1502 +1
==========================================
+ Hits 4194 4195 +1
Misses 158 158
Partials 223 223
Continue to review full report at Codecov.
|
Conduitry
reviewed
Mar 12, 2018
src/generators/nodes/Element.ts
Outdated
| @@ -216,7 +216,9 @@ export default class Element extends Node { | |||
| if (this._needsCssAttribute && !this.generator.customElement) { | |||
| if (!this.attributes.find(a => a.type === 'Attribute' && a.name === 'class')) { | |||
| block.builders.hydrate.addLine( | |||
| `${name}.className = "${this.generator.stylesheet.id}";` | |||
| this.namespace === namespaces.svg | |||
There was a problem hiding this comment.
Elsewhere I think we always use setAttribute if any namespace is set at all, not just if the SVG one is set. I'm really not sure what the practical difference is, but do we want to do the same thing here?
There was a problem hiding this comment.
ah, you're right — I don't think it does make any practical difference (idk, MathML?) but consistency is valuable. updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1224