fix: improve consttag ordering in non-runes mode

[trueadm]

Fixes #11450

[changeset-bot]

🦋 Changeset detected

Latest commit: f4491cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

Got the cyclical dependency detection working, but in the process uncovered a bug that's been lying dormant for a very long time. It turns out that when we call create_block (both the client and server implementations of it), we skip over the universal visitor that updates context.state.scope with the fragment's scope. Because of that, while this works...

{#if true}
  {@const a = b}
  {@const b = 42}
  <h1>{a}</h1>
{/if}

..this (for example) does not:

<Child>
  {@const a = b}
  {@const b = 42}
  <h1>{a}</h1>
</Child>

Ideally we would only call create_block inside the Fragment visitors (perhaps we move the create_block logic inside the visitor?) but as things stand that doesn't quite work. Looking into it

[Rich-Harris]

This turned into a bit of a rabbit hole but I'm glad to have uncovered that bug as I've no doubt it would have blown up in our faces at some point. Have removed create_block from the server code, but still need to do something similar for client code