Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ["default"] instead of .default in legacy mode #1169

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #1166

@codecov-io
Copy link

codecov-io commented Feb 10, 2018

Codecov Report

Merging #1169 into master will increase coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1169      +/-   ##
==========================================
+ Coverage   91.75%   91.82%   +0.06%     
==========================================
  Files         126      126              
  Lines        4563     4695     +132     
  Branches     1487     1568      +81     
==========================================
+ Hits         4187     4311     +124     
+ Misses        158      157       -1     
- Partials      218      227       +9
Impacted Files Coverage Δ
src/generators/nodes/Slot.ts 89.83% <100%> (+0.17%) ⬆️
src/generators/nodes/Component.ts 93.99% <66.66%> (-1.23%) ⬇️
src/generators/dom/index.ts 97.18% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173792f...38bf5b1. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 4ccc2ad into master Feb 23, 2018
@Rich-Harris Rich-Harris deleted the gh-1166 branch February 23, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output ['default'] instead of .default
2 participants