Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing modernAst in validate_component_options #11542

Merged
merged 3 commits into from
May 14, 2024

Conversation

xeho91
Copy link
Contributor

@xeho91 xeho91 commented May 10, 2024

PR #11191 introduced a feature - modernAst instead of modern.
Following the interface of CompileOptions:


Also, added missing modernAst in validate_component_options, which broke the test parse-modern.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Add missing `modernAst` in `validate_component_options`.
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: f56e1a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xeho91 xeho91 changed the title fix: replace modern to modernAst fix: add missing modernAst in validate_component_options May 10, 2024
@xeho91
Copy link
Contributor Author

xeho91 commented May 10, 2024

@dummdidumm Should I add changeset for this one as well?

@xeho91 xeho91 requested a review from dummdidumm May 11, 2024 10:38
@dummdidumm dummdidumm merged commit fd43702 into sveltejs:main May 14, 2024
6 of 8 checks passed
@xeho91 xeho91 deleted the fix-compile-parse-modern branch May 14, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants