Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix escaping of sigils in SSR non-top-level <script> and <style> #1097

Merged
merged 1 commit into from
Jan 13, 2018

Conversation

Conduitry
Copy link
Member

Oversight in my PR for #1082. We should also make sure to cover this in #1087 once that test is working.

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #1097 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1097   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         123      123           
  Lines        4493     4493           
  Branches     1447     1447           
=======================================
  Hits         4114     4114           
  Misses        162      162           
  Partials      217      217
Impacted Files Coverage Δ
...nerators/server-side-rendering/visitors/Element.ts 84.84% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2537db9...7ee44af. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 8057884 into master Jan 13, 2018
@Rich-Harris Rich-Harris deleted the gh-1082-b branch January 13, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants