-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make $props()
rune non-generic
#10694
Conversation
🦋 Changeset detectedLatest commit: c19754c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me quickly test if language-tools also support the non-generic notation
Damn I'll need to update my code again. LOL! |
Yeah that looks sensible |
The
$props()
rune should not accept a type argument. Instead, component authors should type their props like any other variable declaration:Otherwise, things can break because you're relying on inference:
In the above image you can see that the type is widened from
string
tostring | number
because when using the generics notation, TypeScript takes the initializer into account when generating the type - which is not what we want.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint