Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger again when window listener already handled #10611

Merged
merged 4 commits into from
Feb 23, 2024
Merged

fix: trigger again when window listener already handled #10611

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4c1818
fix: trigger again when window listener already handled
xxkl1 Feb 22, 2024
4779f15
docs: add changeset
xxkl1 Feb 22, 2024
ff1ae81
better changeset, use owner_document, comment
dummdidumm Feb 23, 2024
7039ae1
Update packages/svelte/src/internal/client/render.js
dummdidumm Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-impalas-bow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: trigger again when window listener already handled
9 changes: 5 additions & 4 deletions packages/svelte/src/internal/client/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,12 +1402,13 @@ function handle_event_propagation(handler_element, event) {
const handled_at = event.__root;
if (handled_at) {
const at_idx = path.indexOf(handled_at);
if (at_idx !== -1 && handler_element === document) {
// This is the fallback document listener but the event was already handled
// -> ignore, but set handle_at to document so that we're resetting the event
// @ts-ignore
if (at_idx !== -1 && (handler_element === document || handler_element === window)) {
Copy link
Contributor

@trueadm trueadm Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just occurred to me that we should probably be using the ownerDocument from the target element because of iframes rather than the global document object.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first look I thought "yeah makes sense", but on second look: The fallback event listener is set to document, too - should that one be using container_target.ownerDocument, too? Either way, this sounds like something we can talk about separately.

// This is the fallback document/window listener but the event was already handled
// -> ignore, but set handle_at to document/window so that we're resetting the event
// chain in case someone manually dispatches the same event object again.
// @ts-expect-error
event.__root = document;
event.__root = handler_element;
return;
}
// We're deliberately not skipping if the index is higher, because
Expand Down
Loading