Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on unused events/transitions #1052

Merged
merged 2 commits into from
Dec 30, 2017
Merged

Warn on unused events/transitions #1052

merged 2 commits into from
Dec 30, 2017

Conversation

Rich-Harris
Copy link
Member

Follow-up to #1050. It doesn't do helpers, because that would require a bit more work that I can't be bothered to do right now.

Fixes #1051

@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #1052 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   92.02%   92.05%   +0.02%     
==========================================
  Files         121      121              
  Lines        4376     4392      +16     
  Branches     1410     1415       +5     
==========================================
+ Hits         4027     4043      +16     
  Misses        148      148              
  Partials      201      201
Impacted Files Coverage Δ
src/generators/server-side-rendering/index.ts 95.77% <ø> (ø) ⬆️
src/validate/html/validateElement.ts 89.36% <100%> (+0.47%) ⬆️
src/validate/index.ts 89.09% <100%> (+2.42%) ⬆️
src/generators/dom/index.ts 95.48% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f8f8a...ab94066. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 57ec514 into master Dec 30, 2017
@Rich-Harris Rich-Harris deleted the gh-1051 branch December 30, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants