-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: source maps for preprocessors + tests #10459
Conversation
🦋 Changeset detectedLatest commit: 86f2de6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Alright, the only thing left is the test that was added in order to address #6092, which we can always tackle later if we chose to reimplement it. Gonna merge this as soon as it's green. |
Similar to a change that was part of #10459 Fixes sveltejs/svelte-loader#238
…ap (#13546) Similar to a change that was part of #10459 Fixes sveltejs/svelte-loader#238
Add source map merging for preprocessors and get tests passing.
sources
array where they weren't calculated relative to the input correctlyenableSourcemap
, it was needed at some point, not sure if anymore, and not sure how much hassle it would be to bring back. In the spirit of "as little breaking changes as possible" probably ok to bring back if not too much hassle? Edit: We decided to remove it but only log a warning, the reason this was introduced was to mitigate a bug in Vite which occured when having the source map inlined into the SSR'd output. Since SSR doesn't contain inlined CSS anymore (and if it did, we would omit the source map) the reason for which it was introduced no longer existsbind:x
isn't mapped anymore, not sure if this is a problem in Svelte or in esrap. Edit: It seems this never worked for thebind:x
shorthand and that test is skipped in Svelte 4. Svelte 4 addsloc
entries to a handful of locations by hand for things that should be mapped.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint