Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check files with names like [foo].html work on windows #1010

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

Rich-Harris
Copy link
Member

For Sapper (which I'll move over to this organisation soon, once it's a less of a big pile of TODOs), I've settled on the following convention for declaring routes: a file like routes/post/[id].html translates to /post/:id — i.e. visiting /post/xyz causes [id].html to be rendered with params: { id: 'xyz' }.

Just need to make sure that Windows doesn't ruin the party, hence this PR.

@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #1010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         115      115           
  Lines        4297     4297           
  Branches     1369     1369           
=======================================
  Hits         3956     3956           
  Misses        148      148           
  Partials      193      193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbe088...ffd06c4. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 0da8191 into master Dec 12, 2017
@Rich-Harris Rich-Harris deleted the windows-sanity-check branch December 12, 2017 15:13
@Rich-Harris
Copy link
Member Author

it works! excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants