Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing plaintext-only type for contenteditable attribute. #9181

Closed
KaiErikNiermann opened this issue Sep 5, 2023 · 1 comment
Closed

Missing plaintext-only type for contenteditable attribute. #9181

KaiErikNiermann opened this issue Sep 5, 2023 · 1 comment
Labels
good first issue A small, encapsulated issue, ideal for a new contributor to Svelte to tackle. types / typescript

Comments

@KaiErikNiermann
Copy link
Contributor

KaiErikNiermann commented Sep 5, 2023

Describe the bug

In the type definitions for Svelte HTML the type of contenteditable is missing plaintext-only. This raises an obvious type error when trying to use it and can be fixed by adding 'plaintext-only' to the types. Its not yet supported in all browsers and relativley new so I can understand if its not been included for those reasons. Just a very mild annoyance. If this should be added I can quickly PR.

Reproduction

Cannot reproduce in REPL as it does not use TS.

Logs

Type '"plaintext-only"' is not assignable to type '"inherit" | Booleanish | null | undefined'.

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 5.14 GB / 7.72 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 19.7.0 - /usr/local/bin/node
    npm: 9.8.1 - /usr/local/bin/npm
    pnpm: 8.6.9 - ~/.local/share/pnpm/pnpm
  Browsers:
    Chrome: 116.0.5845.140

Severity

annoyance

@jasonlyu123 jasonlyu123 added the good first issue A small, encapsulated issue, ideal for a new contributor to Svelte to tackle. label Sep 13, 2023
dinesh-singaria added a commit to dinesh-singaria/svelte that referenced this issue Sep 13, 2023
dinesh-singaria added a commit to dinesh-singaria/svelte that referenced this issue Sep 13, 2023
fix:sveltejs#9181 adding 'plaintext-only' to the types of contenteditable
dinesh-singaria added a commit to dinesh-singaria/svelte that referenced this issue Sep 13, 2023
@joao-conde
Copy link

Hello, is this being fixed by dinesh-singaria ? What's missing and how can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A small, encapsulated issue, ideal for a new contributor to Svelte to tackle. types / typescript
Projects
None yet
Development

No branches or pull requests

3 participants