Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal variables showing up in svelte:options bind:props #2038

Closed
halfnelson opened this issue Feb 2, 2019 · 0 comments · Fixed by #2083
Closed

Internal variables showing up in svelte:options bind:props #2038

halfnelson opened this issue Feb 2, 2019 · 0 comments · Fixed by #2083
Labels
awaiting submitter needs a reproduction, or clarification
Milestone
3.0

Comments

@halfnelson
Copy link
Contributor

v3 alpha27

When using <svelte:options bind:props in a component where there is slot default content, the props object contains $$slot_default and $$scope. This causes an error when using the spread operator on html elements eg <h1 {...props}
https://v3.svelte.technology/repl?version=3.0.0-alpha27&gist=b34f72aee305df48c06618219306d1db

the $ prefixed prop elements are not there if there is no default slot content
@Conduitry Conduitry added this to the 3.x milestone Feb 3, 2019
@Conduitry Conduitry added the awaiting submitter needs a reproduction, or clarification label Feb 3, 2019
Rich-Harris added a commit that referenced this issue Feb 14, 2019
@Rich-Harris
remove internal gubbins when using bind:props - fixes #2038
a50c84e
@Rich-Harris Rich-Harris mentioned this issue Feb 14, 2019
Merged
Rich-Harris added a commit that referenced this issue Feb 17, 2019
@Rich-Harris
Merge pull request #2083 from sveltejs/gh-2038
94dfeec 
remove internal gubbins when using bind:props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting submitter needs a reproduction, or clarification
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

remove internal gubbins when using bind:props sveltejs/svelte
2 participants
@halfnelson @Conduitry