Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats.warnings does not include all warnings #1918

Closed
Conduitry opened this issue Dec 28, 2018 · 0 comments · Fixed by #1926
Closed

stats.warnings does not include all warnings #1918

Conduitry opened this issue Dec 28, 2018 · 0 comments · Fixed by #1926
Labels
bug
Milestone
3.0

Comments

@Conduitry
Copy link
Member

stats.warnings does not include any unused CSS selector warnings. There may be other warnings it's missing. We need to call stats.warn instead of options.onwarn whenever we have a warning.

This is present in v2 and v3.
@Conduitry Conduitry added the bug label Dec 28, 2018
@Conduitry Conduitry added this to the 3.x milestone Dec 28, 2018
Rich-Harris added a commit that referenced this issue Dec 29, 2018
@Rich-Harris
always use stats.warn instead of options.onwarn - fixes #1918
88c6740
@Rich-Harris Rich-Harris mentioned this issue Dec 29, 2018
Merged
Rich-Harris added a commit that referenced this issue Dec 29, 2018
@Rich-Harris
Merge pull request #1926 from sveltejs/gh-1918
4cb2b8d 
always use stats.warn instead of options.onwarn
@idcmardelplata idcmardelplata mentioned this issue Feb 9, 2021
Open
@snyk-bot snyk-bot mentioned this issue Aug 11, 2021
Open
@konlanz konlanz mentioned this issue May 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

always use stats.warn instead of options.onwarn sveltejs/svelte
1 participant
@Conduitry