Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMD format references dependencies with .html suffix #144

Closed
GrantDG opened this issue Dec 7, 2016 · 1 comment · Fixed by #206
Closed

AMD format references dependencies with .html suffix #144

GrantDG opened this issue Dec 7, 2016 · 1 comment · Fixed by #206
Labels
bug
Milestone
ASAP

Comments

@GrantDG
Copy link

GrantDG commented Dec 7, 2016

When using the AMD format, the following is generated as the AMD module definition:

define([ './CategoryChooser.html' ], function ( CategoryChooser ) { 'use strict';

it should be:

define([ './CategoryChooser' ], function ( CategoryChooser ) { 'use strict';
@Rich-Harris Rich-Harris added this to the ASAP milestone Dec 10, 2016
Rich-Harris added a commit that referenced this issue Dec 17, 2016
@Rich-Harris
remove extensions from AMD dependencies – fixes #144
9f6d1b2
@Rich-Harris Rich-Harris mentioned this issue Dec 17, 2016
Merged
Rich-Harris added a commit that referenced this issue Dec 17, 2016
@Rich-Harris
Merge pull request #206 from sveltejs/gh-144
1c3f144 
remove extensions from AMD dependencies
@Rich-Harris
Copy link
Member

Rich-Harris commented Dec 17, 2016 •
edited
Loading

Fixed in 1.3.1, thanks. I do not miss dealing with AMD's quirks...

@konlanz konlanz mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
ASAP
Development

Successfully merging a pull request may close this issue.

remove extensions from AMD dependencies sveltejs/svelte
2 participants
@GrantDG @Rich-Harris