Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data property is added twice for components #1301

Closed
Rich-Harris opened this issue Apr 2, 2018 · 2 comments · Fixed by #1302
Closed

Data property is added twice for components #1301

Rich-Harris opened this issue Apr 2, 2018 · 2 comments · Fixed by #1302
Labels

Comments

@Rich-Harris
Copy link
Member

REPL. This code gets generated:

var child = new Child({
	root: component.root,
	data: child_initial_data,
	data: child_initial_data,
	_bind: function(changed, childState) {
		var state = component.get(), newState = {};
		if (!child_updating.items && changed.items) {
			newState.items = childState.items;
		}
		component._set(newState);
		child_updating = {};
	}
});

Should be a nice easy fix

@Rich-Harris Rich-Harris added the bug label Apr 2, 2018
Rich-Harris added a commit that referenced this issue Apr 2, 2018
Rich-Harris added a commit that referenced this issue Apr 3, 2018
@funkybob
Copy link
Contributor

funkybob commented Apr 3, 2018

In that repl this line is also duplicated:

		p: function update(changed, state) {
			var child_changes = {};
			var child_changes = {};

@Rich-Harris Rich-Harris reopened this Apr 3, 2018
Rich-Harris added a commit that referenced this issue Apr 4, 2018
@Rich-Harris
Copy link
Member Author

fixed in b4ade9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants