Svelte 5: HMR only updates once #12506
Comments
|
Same issue here - first HMR update works, but nothing after. Linking the problematic PR: #12454 |
|
Same Here, a new project with tailwindcss the HMR only works once. |
|
It's this: Rich said they are aware and will fix when they have a chance to fix. |
It's not the same, there are no components in the repro and that one started in |
|
is same issue? |
Yep! |
|
Hey all, I am experiencing the same issue. I started a new Svelte 5 project to test it out. I am currently running: I am using the I was going crazy trying to figure out the root cause of this. Good to see I'm not the only one experiencing the hmr issue. For the time being, i'm going to roll back my svelte 5 version to: |
The previous HMR logic created a new wrapper and source per HMR update, which meant things would either get wrapped more and more (prior to #12454) or would not get updated after the first update because the reference to the original would get lost (after #12454). This fixes that by creating a registry within the HMR wrappers by filename are stored, retrieved and its signals updated. That way nothing gets lost, and nothing gets wrapped more than needed. Fixes #12506
|
193 still issue...😭 |
|
Fixed by #12547 |
Describe the bug
Svelte 5: HMR only updates once.
Worked in
5.0.0-next.186, broken from5.0.0-next.187.Reproduction
https://stackblitz.com/github/henrikvilhelmberglund/svelte5-hmr-repro?file=src%2Froutes%2F%2Bpage.svelte
or
https://github.com/henrikvilhelmberglund/svelte5-hmr-repro
ni && nr devaka install and run dev+page.svelteExpected: It disappears from the page.
Result: It doesn't disappear from the page.
If you F5 you can get one HMR again but nothing after that.
Logs
No response
System Info
System: OS: Windows 10 10.0.19045 CPU: (8) x64 Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz Memory: 3.34 GB / 15.95 GB Binaries: Node: 20.14.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.22 - C:\Program Files\nodejs\yarn.CMD npm: 10.7.0 - C:\Program Files\nodejs\npm.CMD bun: 1.1.18 - ~\.bun\bin\bun.EXE Browsers: Edge: Chromium (126.0.2592.102) Internet Explorer: 11.0.19041.4355 npmPackages: svelte: 5.0.0-next.187 => 5.0.0-next.187Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: