Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children duplication of list items rendered within components after v 5.0.0-next.179 #12447

Closed
AleksandrIvanenko opened this issue Jul 15, 2024 · 0 comments · Fixed by #12449
Closed
Milestone

Comments

@AleksandrIvanenko
Copy link

Describe the bug

Some strange duplication of children in lists:
image

Reproduced only for list items rendered within components containing additional tag before {@render children()}, such as the span tag in the reproduction example:
image

Reproduction

Link to reproduction - https://codesandbox.io/p/devbox/stupefied-scott-qs9hzs.

Logs

No response

System Info

System:
    OS: Linux 6.1 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
    CPU: (2) x64 AMD EPYC
    Memory: 1.98 GB / 4.01 GB
    Container: Yes
    Shell: Unknown
  Binaries:
    Node: 20.12.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.5.0 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/share/npm-global/bin/pnpm
  npmPackages:
    svelte: 5.0.0-next.184 => 5.0.0-next.184

Severity

blocking all usage of svelte

@dummdidumm dummdidumm added this to the 5.0 milestone Jul 15, 2024
dummdidumm added a commit that referenced this issue Jul 15, 2024
The logic that was there didn't take components into account. The underlying problem is that the parent isn't properly set to `Fragment` in all cases because of nested `visit` calls we do in some places.

Fixes #12447
trueadm pushed a commit that referenced this issue Jul 16, 2024
* fix: prevent whitespaces merging across component boundaries

The logic that was there didn't take components into account. The underlying problem is that the parent isn't properly set to `Fragment` in all cases because of nested `visit` calls we do in some places.

Fixes #12447

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants