Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document contributor's guide. #1103

Closed
arxpoetica opened this issue Jan 12, 2018 · 3 comments
Closed

Document contributor's guide. #1103

arxpoetica opened this issue Jan 12, 2018 · 3 comments
Assignees

Comments

@arxpoetica
Copy link
Member

From Gitter convo with Rich:

things like 'how to write tests and where to put them' would probably help people when reporting bugs (since PRs with failing tests are gold, second only to PRs with tests and fixes) and the test suite is a bit wild and woolly. lots of assumed knowledge in there, like how to 'solo' a test, and knowing to use snapshot tests sparingly

@arxpoetica arxpoetica self-assigned this Jan 12, 2018
@arxpoetica
Copy link
Member Author

@asweingarten threw down some awesome thoughts on this, which should give me a leg up while writing this:
https://drive.google.com/file/d/1A6PDHohwHsNwZk0udFU7JYStoK5uMZdb/view
https://gitter.im/sveltejs/svelte?at=5a58e8525a9ebe4f757c3a76

See also his work on #1083 while writing up his thoughts. And the PR: #1099

@antony
Copy link
Member

antony commented Dec 24, 2019

@arxpoetica is this a duplicate / the same issue as #3791 ?

@arxpoetica
Copy link
Member Author

@antony similar but different. However, it looks like @tanhauhau did this in #3765

WOOHOO!!!

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants