Merge pull request #906 from m59peacemaker/css-attribute-name-only-bug

Fixes #905 css attribute name only bug
sveltejs · Oct 28, 2017 · fee5754 · fee5754
2 parents 1dad8f1 + 97d8125
commit fee5754
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/src/css/Selector.ts b/src/css/Selector.ts
@@ -224,6 +224,7 @@ function attributeMatches(node: Node, name: string, expectedValue: string, opera
 	if (!attr) return false;
 	if (attr.value === true) return operator === null;
 	if (attr.value.length > 1) return true;
+	if (!expectedValue) return true;
 
 	const pattern = operators[operator](expectedValue, caseInsensitive ? 'i' : '');
 	const value = attr.value[0];

diff --git a/test/css/samples/attribute-selector-only-name/_config.js b/test/css/samples/attribute-selector-only-name/_config.js
@@ -0,0 +1,3 @@
+export default {
+	cascade: false
+};
diff --git a/test/css/samples/attribute-selector-only-name/expected.css b/test/css/samples/attribute-selector-only-name/expected.css
@@ -0,0 +1 @@
+[foo][svelte-xyz]{color:red}[baz][svelte-xyz]{color:blue}
diff --git a/test/css/samples/attribute-selector-only-name/input.html b/test/css/samples/attribute-selector-only-name/input.html
@@ -0,0 +1,11 @@
+<div foo='bar'></div>
+<div baz></div>
+
+<style>
+	[foo] {
+		color: red;
+	}
+	[baz] {
+		color: blue;
+	}
+</style>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		[foo][svelte-xyz]{color:red}[baz][svelte-xyz]{color:blue}