Merge pull request #1969 from sveltejs/gh-1852

better handling of bare attribute names in DOM mode
sveltejs · Jan 13, 2019 · efa7ad6 · efa7ad6
2 parents 2d3dbdd + d033c83
commit efa7ad6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/compile/render-dom/wrappers/Element/Attribute.ts b/src/compile/render-dom/wrappers/Element/Attribute.ts
@@ -187,7 +187,7 @@ export default class AttributeWrapper {
 						? `${element.var}.${propertyName} = ${value};`
 						: isDataSet
 							? `${element.var}.dataset.${camelCaseName} = ${value};`
-							: `${method}(${element.var}, "${name}", ${value});`
+							: `${method}(${element.var}, "${name}", ${value === true ? '""' : value});`
 			);
 
 			block.builders.hydrate.addLine(statement);
@@ -207,9 +207,9 @@ export default class AttributeWrapper {
 	}
 
 	stringify() {
-		const value = this.node.chunks;
+		if (this.node.isTrue) return '';
 
-		if (value === true) return '';
+		const value = this.node.chunks;
 		if (value.length === 0) return `=""`;
 
 		return `="${value.map(chunk => {

diff --git a/test/runtime/samples/attribute-unknown-without-value/_config.js b/test/runtime/samples/attribute-unknown-without-value/_config.js
@@ -0,0 +1,3 @@
+export default {
+	html: '<div potato=""></div>'
+};
diff --git a/test/runtime/samples/attribute-unknown-without-value/main.html b/test/runtime/samples/attribute-unknown-without-value/main.html
@@ -0,0 +1 @@
+<div potato></div>