Merge pull request #2518 from sveltejs/gh-2510

handle unknown nodes in extract_identifiers
sveltejs · Apr 25, 2019 · c97ee00 · c97ee00
2 parents b111785 + 356a1eb
commit c97ee00
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/compile/utils/scope.ts b/src/compile/utils/scope.ts
@@ -106,7 +106,7 @@ export function extract_names(param: Node) {
 
 export function extract_identifiers(param: Node) {
 	const nodes: Node[] = [];
-	extractors[param.type](nodes, param);
+	extractors[param.type] && extractors[param.type](nodes, param);
 	return nodes;
 }
 

diff --git a/test/runtime/samples/reactive-value-mutate/_config.js b/test/runtime/samples/reactive-value-mutate/_config.js
@@ -0,0 +1,3 @@
+export default {
+	html: `{"bar":42}`
+};
diff --git a/test/runtime/samples/reactive-value-mutate/main.svelte b/test/runtime/samples/reactive-value-mutate/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	let foo = {};
+	let bar = 42;
+	$: foo.bar = bar;
+</script>
+
+{JSON.stringify(foo)}