Merge pull request #201 from sveltejs/gh-200

don't self-close elements
sveltejs · Dec 15, 2016 · bb24ab6 · bb24ab6
2 parents e016b20 + 92ec869
commit bb24ab6
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 5 deletions.
diff --git a/src/server-side-rendering/compile.js b/src/server-side-rendering/compile.js
@@ -198,8 +198,6 @@ export default function compile ( parsed, source, { filename }) {
 
 			if ( voidElementNames.test( node.name ) ) {
 				element += '>';
-			} else if ( node.children.length === 0 ) {
-				element += '/>';
 			} else {
 				elementDepth += 1;
 				element += '>' + node.children.map( stringify ).join( '' ) + `</${node.name}>`;

diff --git a/test/server-side-rendering/attribute-boolean/_actual.html b/test/server-side-rendering/attribute-boolean/_actual.html
@@ -1 +1 @@
-<textarea readonly/>
+<textarea readonly></textarea>
diff --git a/test/server-side-rendering/attribute-static/_actual.html b/test/server-side-rendering/attribute-static/_actual.html
@@ -1 +1 @@
-<div class="foo"/>
+<div class="foo"></div>
diff --git a/test/server-side-rendering/empty-elements-closed/_actual.html b/test/server-side-rendering/empty-elements-closed/_actual.html
@@ -0,0 +1,2 @@
+<a></a>
+	 <p></p>
diff --git a/test/server-side-rendering/empty-elements-closed/_expected.html b/test/server-side-rendering/empty-elements-closed/_expected.html
@@ -0,0 +1,2 @@
+<a></a>
+<p></p>
diff --git a/test/server-side-rendering/empty-elements-closed/main.html b/test/server-side-rendering/empty-elements-closed/main.html
@@ -0,0 +1,2 @@
+<a></a>
+<p></p>
diff --git a/test/server-side-rendering/static-div/_actual.html b/test/server-side-rendering/static-div/_actual.html
@@ -1 +1 @@
-<div/>
+<div></div>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<textarea readonly/>
		<textarea readonly></textarea>