chore: upgrade aria-query and axobject-query (#8724)

Co-authored-by: gtmnayan <[email protected]>
sveltejs · Jun 14, 2023 · 83e9178 · 83e9178
1 parent cc1f4bc
commit 83e9178
Show file tree

Hide file tree

Showing 7 changed files with 55 additions and 206 deletions.
diff --git a/packages/svelte/package.json b/packages/svelte/package.json
@@ -103,8 +103,8 @@
     "@ampproject/remapping": "^2.2.1",
     "@jridgewell/sourcemap-codec": "^1.4.15",
     "acorn": "^8.8.2",
-    "aria-query": "^5.1.3",
-    "axobject-query": "^3.1.1",
+    "aria-query": "^5.2.1",
+    "axobject-query": "^3.2.1",
     "code-red": "^1.0.0",
     "css-tree": "^2.3.1",
     "estree-walker": "^3.0.3",
@@ -118,7 +118,6 @@
     "@rollup/plugin-commonjs": "^24.1.0",
     "@rollup/plugin-json": "^6.0.0",
     "@rollup/plugin-node-resolve": "^15.0.2",
-    "@rollup/plugin-replace": "^5.0.2",
     "@sveltejs/eslint-config": "^6.0.4",
     "@types/aria-query": "^5.0.1",
     "@types/estree": "^1.0.1",
@@ -133,7 +132,6 @@
     "source-map": "^0.7.4",
     "tiny-glob": "^0.2.9",
     "typescript": "^5.0.4",
-    "util": "^0.12.5",
     "vitest": "^0.31.1"
   }
 }
diff --git a/packages/svelte/rollup.config.js b/packages/svelte/rollup.config.js
@@ -1,6 +1,5 @@
 import fs from 'node:fs';
 import { createRequire } from 'node:module';
-import replace from '@rollup/plugin-replace';
 import resolve from '@rollup/plugin-node-resolve';
 import commonjs from '@rollup/plugin-commonjs';
 import json from '@rollup/plugin-json';
@@ -25,19 +24,8 @@ export default [
 	{
 		input: 'src/compiler/index.js',
 		plugins: [
-			replace({
-				preventAssignment: true,
-				values: {
-					'process.env.NODE_DEBUG': false // appears inside the util package
-				}
-			}),
 			{
 				resolveId(id) {
-					// util is a built-in module in Node.js, but we want a self-contained compiler bundle
-					// that also works in the browser, so we load its polyfill instead
-					if (id === 'util') {
-						return require.resolve('./node_modules/util'); // just 'utils' would resolve this to the built-in module
-					}
 					// Must import from the `css-tree` browser bundled distribution due to `createRequire` usage if importing from css-tree directly
 					if (id === 'css-tree') {
 						return require.resolve('./node_modules/css-tree/dist/csstree.esm.js');

diff --git a/...te/test/validator/samples/a11y-no-interactive-element-to-noninteractive-role/input.svelte b/...te/test/validator/samples/a11y-no-interactive-element-to-noninteractive-role/input.svelte
@@ -143,6 +143,6 @@
 <menuitem role="listitem" />
 <option class="foo" role="listitem" />
 <select class="foo" role="listitem" />
-<summary role="listitem" />
+<summary role="listitem" /> // TODO: https://github.com/sveltejs/svelte/issues/8728
 <textarea class="foo" role="listitem" />
 <tr role="listitem" />
diff --git a/...e/test/validator/samples/a11y-no-interactive-element-to-noninteractive-role/warnings.json b/...e/test/validator/samples/a11y-no-interactive-element-to-noninteractive-role/warnings.json
@@ -671,18 +671,6 @@
 			"line": 145
 		}
 	},
-	{
-		"code": "a11y-no-interactive-element-to-noninteractive-role",
-		"end": {
-			"column": 27,
-			"line": 146
-		},
-		"message": "A11y: <summary> cannot have role 'listitem'",
-		"start": {
-			"column": 0,
-			"line": 146
-		}
-	},
 	{
 		"code": "a11y-no-interactive-element-to-noninteractive-role",
 		"end": {

diff --git a/...te/test/validator/samples/a11y-no-noninteractive-element-to-interactive-role/input.svelte b/...te/test/validator/samples/a11y-no-noninteractive-element-to-interactive-role/input.svelte
@@ -2,7 +2,7 @@
 <article role="button" />
 <aside role="checkbox" aria-checked={false} />
 <blockquote role="columnheader" />
-<body role="combobox" aria-controls={[]} aria-expanded />
+<body role="combobox" aria-controls={[]} aria-expanded /> // TODO: https://github.com/sveltejs/svelte/issues/8728
 <br role="grid" />
 <caption role="gridcell" />
 <dd role="link" />
@@ -18,7 +18,7 @@
 <figure role="option" aria-selected />
 <footer role="radio" aria-checked />
 <form role="radiogroup" />
-<frame role="row" />
+<frame role="row" /> // TODO: https://github.com/sveltejs/svelte/issues/8728
 <h1 role="rowheader">Button</h1>
 <h2 role="scrollbar" aria-controls={[]} aria-valuenow={0} >Button</h2>
 <h3 role="searchbox">Button</h3>
@@ -46,7 +46,7 @@
 <section role="radio" aria-label="radio" aria-checked />
 <table role="menu" />
 <tbody role="searchbox" />
-<td role="button" />
+<td role="button" />  // TODO: https://github.com/sveltejs/svelte/issues/8728
 <tfoot role="listbox" />
 <thead role="slider" aria-valuenow={0} />
 <time role="doc-backlink" />

diff --git a/...e/test/validator/samples/a11y-no-noninteractive-element-to-interactive-role/warnings.json b/...e/test/validator/samples/a11y-no-noninteractive-element-to-interactive-role/warnings.json
@@ -35,18 +35,6 @@
 			"line": 4
 		}
 	},
-	{
-		"code": "a11y-no-noninteractive-element-to-interactive-role",
-		"end": {
-			"column": 57,
-			"line": 5
-		},
-		"message": "A11y: Non-interactive element <body> cannot have interactive role 'combobox'",
-		"start": {
-			"column": 0,
-			"line": 5
-		}
-	},
 	{
 		"code": "a11y-no-noninteractive-element-to-interactive-role",
 		"end": {
@@ -203,18 +191,6 @@
 			"line": 20
 		}
 	},
-	{
-		"code": "a11y-no-noninteractive-element-to-interactive-role",
-		"end": {
-			"column": 20,
-			"line": 21
-		},
-		"message": "A11y: Non-interactive element <frame> cannot have interactive role 'row'",
-		"start": {
-			"column": 0,
-			"line": 21
-		}
-	},
 	{
 		"code": "a11y-no-noninteractive-element-to-interactive-role",
 		"end": {
@@ -563,18 +539,6 @@
 			"line": 48
 		}
 	},
-	{
-		"code": "a11y-no-noninteractive-element-to-interactive-role",
-		"end": {
-			"column": 20,
-			"line": 49
-		},
-		"message": "A11y: Non-interactive element <td> cannot have interactive role 'button'",
-		"start": {
-			"column": 0,
-			"line": 49
-		}
-	},
 	{
 		"code": "a11y-no-noninteractive-element-to-interactive-role",
 		"end": {