encapsulate local styles inside global ones - fixes #1618

sveltejs · Aug 4, 2018 · 7eaf5dc · 7eaf5dc
1 parent 6012c96
commit 7eaf5dc
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/src/css/Selector.ts b/src/css/Selector.ts
@@ -30,6 +30,7 @@ export default class Selector {
 
 	apply(node: Node, stack: Node[]) {
 		const toEncapsulate: Node[] = [];
+
 		applySelector(this.stylesheet, this.localBlocks.slice(), node, stack.slice(), toEncapsulate);
 
 		if (toEncapsulate.length > 0) {
@@ -132,10 +133,6 @@ export default class Selector {
 	}
 }
 
-function isDescendantSelector(selector: Node) {
-	return selector.type === 'WhiteSpace' || selector.type === 'Combinator';
-}
-
 function applySelector(stylesheet: Stylesheet, blocks: Block[], node: Node, stack: Node[], toEncapsulate: any[]): boolean {
 	const block = blocks.pop();
 	if (!block) return false;
@@ -145,7 +142,6 @@ function applySelector(stylesheet: Stylesheet, blocks: Block[], node: Node, stac
 	}
 
 	let i = block.selectors.length;
-	let j = stack.length;
 
 	while (i--) {
 		const selector = block.selectors[i];
@@ -202,12 +198,18 @@ function applySelector(stylesheet: Stylesheet, blocks: Block[], node: Node, stac
 				}
 			}
 
+			if (blocks.every(block => block.global)) {
+				toEncapsulate.push({ node, block });
+				return true;
+			}
+
 			return false;
 		} else if (block.combinator.name === '>') {
 			if (applySelector(stylesheet, blocks, stack.pop(), stack, toEncapsulate)) {
 				toEncapsulate.push({ node, block });
 				return true;
 			}
+
 			return false;
 		}
 

diff --git a/test/css/samples/local-inside-global/expected.css b/test/css/samples/local-inside-global/expected.css
@@ -0,0 +1 @@
+div .foo.svelte-xyz{color:red}div>.foo.svelte-xyz{font-weight:bold}
diff --git a/test/css/samples/local-inside-global/input.html b/test/css/samples/local-inside-global/input.html
@@ -0,0 +1,11 @@
+<p class='foo'>red/bold</p>
+
+<style>
+	:global(div) .foo {
+		color: red;
+	}
+
+	:global(div) > .foo {
+		font-weight: bold;
+	}
+</style>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		div .foo.svelte-xyz{color:red}div>.foo.svelte-xyz{font-weight:bold}