Merge pull request #1378 from sveltejs/gh-1286

recalculate each block values lazily
sveltejs · Apr 29, 2018 · 7246997 · 7246997
2 parents d8ca0e3 + f0bf1ef
commit 7246997
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/compile/nodes/EachBlock.ts b/src/compile/nodes/EachBlock.ts
@@ -443,9 +443,9 @@ export default class EachBlock extends Node {
 				`;
 
 			block.builders.update.addBlock(deindent`
-				var ${each_block_value} = ${snippet};
-
 				if (${condition}) {
+					${each_block_value} = ${snippet};
+
 					for (var #i = ${start}; #i < ${each_block_value}.${length}; #i += 1) {
 						var ${this.each_context} = @assign(@assign({}, ctx), {
 							${this.contextProps.join(',\n')}

diff --git a/test/js/samples/deconflict-builtins/expected-bundle.js b/test/js/samples/deconflict-builtins/expected-bundle.js
@@ -186,9 +186,9 @@ function create_main_fragment(component, ctx) {
 		},
 
 		p: function update(changed, ctx) {
-			var each_value = ctx.createElement;
-
 			if (changed.createElement) {
+				each_value = ctx.createElement;
+
 				for (var i = 0; i < each_value.length; i += 1) {
 					var each_context = assign(assign({}, ctx), {
 						each_value: each_value,

diff --git a/test/js/samples/deconflict-builtins/expected.js b/test/js/samples/deconflict-builtins/expected.js
@@ -34,9 +34,9 @@ function create_main_fragment(component, ctx) {
 		},
 
 		p: function update(changed, ctx) {
-			var each_value = ctx.createElement;
-
 			if (changed.createElement) {
+				each_value = ctx.createElement;
+
 				for (var i = 0; i < each_value.length; i += 1) {
 					var each_context = assign(assign({}, ctx), {
 						each_value: each_value,

diff --git a/test/js/samples/each-block-changed-check/expected-bundle.js b/test/js/samples/each-block-changed-check/expected-bundle.js
@@ -192,9 +192,9 @@ function create_main_fragment(component, ctx) {
 		},
 
 		p: function update(changed, ctx) {
-			var each_value = ctx.comments;
-
 			if (changed.comments || changed.elapsed || changed.time) {
+				each_value = ctx.comments;
+
 				for (var i = 0; i < each_value.length; i += 1) {
 					var each_context = assign(assign({}, ctx), {
 						each_value: each_value,

diff --git a/test/js/samples/each-block-changed-check/expected.js b/test/js/samples/each-block-changed-check/expected.js
@@ -38,9 +38,9 @@ function create_main_fragment(component, ctx) {
 		},
 
 		p: function update(changed, ctx) {
-			var each_value = ctx.comments;
-
 			if (changed.comments || changed.elapsed || changed.time) {
+				each_value = ctx.comments;
+
 				for (var i = 0; i < each_value.length; i += 1) {
 					var each_context = assign(assign({}, ctx), {
 						each_value: each_value,