Merge pull request #1558 from sveltejs/revert-1557-1553-return-from-c…

…ustom-event-handler Revert "Fix for #1553"
sveltejs · Jun 23, 2018 · 685a36f · 685a36f
2 parents 000dc29 + ce575e1
commit 685a36f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/compile/nodes/EventHandler.ts b/src/compile/nodes/EventHandler.ts
@@ -67,12 +67,12 @@ export default class EventHandler extends Node {
 				compiler.code.overwrite(
 					this.insertionPoint,
 					this.insertionPoint + 1,
-					`return ${component}.store.`
+					`${component}.store.`
 				);
 			} else {
 				compiler.code.prependRight(
 					this.insertionPoint,
-					`return ${component}.`
+					`${component}.`
 				);
 			}
 		}

diff --git a/test/js/samples/event-handlers-custom/expected-bundle.js b/test/js/samples/event-handlers-custom/expected-bundle.js
@@ -146,7 +146,7 @@ function create_main_fragment(component, ctx) {
 			button = createElement("button");
 			button.textContent = "foo";
 			foo_handler = foo.call(component, button, function(event) {
-				return component.foo( ctx.bar );
+				component.foo( ctx.bar );
 			});
 		},
 

diff --git a/test/js/samples/event-handlers-custom/expected.js b/test/js/samples/event-handlers-custom/expected.js
@@ -19,7 +19,7 @@ function create_main_fragment(component, ctx) {
 			button = createElement("button");
 			button.textContent = "foo";
 			foo_handler = foo.call(component, button, function(event) {
-				return component.foo( ctx.bar );
+				component.foo( ctx.bar );
 			});
 		},