Merge pull request #2619 from sveltejs/gh-2435

fix resubscriptions inside script block
sveltejs · May 4, 2019 · 6240ed0 · 6240ed0
2 parents 1eca19f + 0d890b1
commit 6240ed0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/compile/render-dom/index.ts b/src/compile/render-dom/index.ts
@@ -203,7 +203,7 @@ export default function dom(
 							const variable = component.var_lookup.get(name);
 							if (variable && (variable.hoistable || variable.global || variable.module)) return;
 
-							if (single) {
+							if (single && !(variable.subscribable && variable.reassigned)) {
 								code.prependRight(node.start, `$$invalidate('${name}', `);
 								code.appendLeft(node.end, `)`);
 							} else {

diff --git a/test/runtime/samples/store-resubscribe-b/_config.js b/test/runtime/samples/store-resubscribe-b/_config.js
@@ -0,0 +1,3 @@
+export default {
+	html: `42`,
+};
diff --git a/test/runtime/samples/store-resubscribe-b/main.svelte b/test/runtime/samples/store-resubscribe-b/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	import { writable } from 'svelte/store';
+	let foo = writable(0);
+	foo = writable(42);
+</script>
+
+{$foo}