fix: avoid extra work in mark_reactions (#12921)

* fix: avoid extra work in mark_reactions * Update packages/svelte/src/internal/client/reactivity/sources.js Co-authored-by: Rich Harris <[email protected]> --------- Co-authored-by: Rich Harris <[email protected]>
sveltejs · Aug 20, 2024 · 4ce23bf · 4ce23bf
1 parent a8c6b92
commit 4ce23bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/flat-moose-arrive.md b/.changeset/flat-moose-arrive.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: avoid extra work in mark_reactions
diff --git a/packages/svelte/src/internal/client/reactivity/sources.js b/packages/svelte/src/internal/client/reactivity/sources.js
@@ -145,8 +145,8 @@ function mark_reactions(signal, status) {
 		var reaction = reactions[i];
 		var flags = reaction.f;
 
-		// Skip any effects that are already dirty
-		if ((flags & DIRTY) !== 0) continue;
+		// If a reaction is already dirty, skip it (but always mark unowned deriveds)
+		if ((flags & (CLEAN | UNOWNED)) === 0) continue;
 
 		// In legacy mode, skip the current effect to prevent infinite loops
 		if (!runes && reaction === current_effect) continue;