Skip to content

Commit

Permalink
chore: failed attempt for binding+events order
Browse files Browse the repository at this point in the history
This is attempt 1 to fix #11138. The idea is that actions, bindings and event directives are added to the "spread attributes" function. That function then first sets all attributes, collects event attributes, then runs actions/bindings/event handlers, and then runs event attributes, to guarantee that event attributes run last.

The sad thing is that it doesn't work. The problem is that bindings or actions could have effects inside them, and those effects would then be tied to the render effect surrounding the "spread attributes" function, and not to the block effect above it, leading to wrong rerun/destroy timings.
  • Loading branch information
dummdidumm committed Apr 18, 2024
1 parent de2d8a0 commit 43f3e51
Show file tree
Hide file tree
Showing 2 changed files with 352 additions and 250 deletions.
Loading

0 comments on commit 43f3e51

Please sign in to comment.