Merge pull request #115 from nikku/validate-computed-prop

Verify computed property dependencies
sveltejs · Dec 5, 2016 · 3935d05 · 3935d05
2 parents 6f2ce42 + 65cdead
commit 3935d05
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/compiler/validate/js/propValidators/computed.js b/compiler/validate/js/propValidators/computed.js
@@ -21,7 +21,14 @@ export default function computed ( validator, prop ) {
 			return;
 		}
 
-		computation.value.params.forEach( param => {
+		const params = computation.value.params;
+
+		if ( params.length === 0 ) {
+			validator.error( `A computed value must depend on at least one property`, computation.value.start );
+			return;
+		}
+
+		params.forEach( param => {
 			const valid = param.type === 'Identifier' || param.type === 'AssignmentPattern' && param.left.type === 'Identifier';
 
 			if ( !valid ) {

diff --git a/test/validator/computed-values/errors.json b/test/validator/computed-values/errors.json
@@ -0,0 +1,8 @@
+[{
+	"message": "A computed value must depend on at least one property",
+	"pos": 49,
+	"loc": {
+		"line": 4,
+		"column": 8
+	}
+}]
diff --git a/test/validator/computed-values/input.html b/test/validator/computed-values/input.html
@@ -0,0 +1,7 @@
+<script>
+	export default {
+		computed: {
+			foo: () => {}
+		}
+	};
+</script>