Merge pull request #2406 from sveltejs/gh-2399

skip observedAttributes where appropriate
sveltejs · Apr 13, 2019 · 1de67e3 · 1de67e3
2 parents 7fcad18 + d2568aa
commit 1de67e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/compile/render-dom/index.ts b/src/compile/render-dom/index.ts
@@ -464,9 +464,10 @@ export default function dom(
 					}
 				}
 
+				${props.length > 0 && deindent`
 				static get observedAttributes() {
 					return ${JSON.stringify(props.map(x => x.export_name))};
-				}
+				}`}
 
 				${body.length > 0 && body.join('\n\n')}
 			}

diff --git a/test/js/samples/css-shadow-dom-keyframes/expected.js b/test/js/samples/css-shadow-dom-keyframes/expected.js
@@ -49,10 +49,6 @@ class Component extends SvelteElement {
 			}
 		}
 	}
-
-	static get observedAttributes() {
-		return [];
-	}
 }
 
 customElements.define("custom-element", Component);
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,10 +49,6 @@ class Component extends SvelteElement { @@
     			}
     		}
     	}
-    	static get observedAttributes() {
-    		return [];
-    	}
     }
     customElements.define("custom-element", Component);
@@ Expand Down @@