Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sass] Tell, that we use legacy api #453

Merged
merged 3 commits into from
Dec 10, 2022
Merged

[sass] Tell, that we use legacy api #453

merged 3 commits into from
Dec 10, 2022

Conversation

bato3
Copy link
Contributor

@bato3 bato3 commented Jan 4, 2022

Partial-fix #452

This patch only fixes the most pressing problem.

There is a question of how to deal with libraries that use legacy importers.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

@dummdidumm
Copy link
Member

dummdidumm commented Jan 9, 2022

The different interface import seems to have broken some tests

@kaisermann
Copy link
Member

This will be merged and used in #562. I actually tried to move to the new compileString API, but couldn't make it work in the testing environment unfortunately.

@kaisermann kaisermann changed the base branch from main to v5 December 10, 2022 12:39
@kaisermann kaisermann merged commit eb74349 into sveltejs:v5 Dec 10, 2022
kaisermann added a commit that referenced this pull request Dec 10, 2022
* [sass] we use leagacy api

* Tell, that we use Legacy API

Co-authored-by: Christian Kaisermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sass] preprocess mixes legacy and current api
3 participants