make the path returned by tmpdir() posix style slashes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Released as 2.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request #34 introduced
posix.jointo fix Windows paths but this doesn't convert the path separators returned fromtmpdirto be/slashes. I think this results in webpack having paths with escaped characters.This path is the result of
posix.join(tmpdir(), 'svelte-12415.css')C:\Users\Bryan\AppData\Local\Temp/svelte-12415.csswebpack reports an error finding a module with this path
C:UsersBryanAppDataLocalTemp/svelte-12415.css.This PR replaces the
\with/to make it posix style.Node Version: v8.9.2
Windows 10 Version: 1709, Build: 116299.125
svelte-loader Version: 2.3.2
Thank you :)