-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix component css reloading on any change #133
Conversation
1b46793
to
d7c1068
Compare
Webpack 4 relies on Maybe there's less hacky way involving inheriting NodeWatchFileSystem and doing that there, but this way is shortest and does the job. Much like having plugin functionality providing virtual files in the loader. Here's some more context: |
Any side-effects? |
I have yet to find them in 4 days of using patched svelte-loader. It was fixed upstream. Keep in mind that by no means I'm an expert in webpack's internals. |
Any updates on this PR? It is hard to understand why this loader uses hacky way to inject virtual files into fs. This work is not just for the loader, it needs to be in loader+plugin (as in minicss-extract-plugin). It is much easier to maintain this loader with ability to update VirtualModulesPlugin using package.json instead of copy/paste some parts of plugin in svelte-loader code directly. |
@trash-and-fire See #59 (comment) for an explanation as to why it wasn't added as a dependency. Also see #136, which pulls in all of the relevant upstream updates, which allows reloading and Webpack 5 support. |
@Smittyvb I would be open to pull request on |
This is now superseded by #146. |
This fixes #131 in a weird way. But it works!