Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared should be resolved #19

Closed
Rich-Harris opened this issue Mar 23, 2017 · 2 comments · Fixed by #20
Closed

shared should be resolved #19

Rich-Harris opened this issue Mar 23, 2017 · 2 comments · Fixed by #20
Labels

Comments

@Rich-Harris
Copy link
Member

rollup-plugin-svelte resolves the shared helpers path relative to the plugin itself. that doesn't happen here, and it seems maybe that's resulting in incorrect behaviour somehow?

@nikku
Copy link
Contributor

nikku commented Mar 23, 2017

Related, but not sure if it is the issue: We should probably keep this test to verify the correct shared inclusion.

@polandj
Copy link

polandj commented Mar 24, 2017

Webpack output of pre-2.0.0:

Hash: edabde4e222b7cfed336
Version: webpack 2.2.1
Time: 335ms
     Asset    Size  Chunks                    Chunk Names
    app.js  286 kB       0  [emitted]  [big]  app
app.js.map  361 kB       0  [emitted]         app
   [0] ./main.svl 10.5 kB {0} [built]
   [2] /Users/jp/Documents/Arduino/chickencoop/~/jquery/dist/jquery.js 268 kB {0} [built]
    + 1 hidden modules

And post 2.0.0

Hash: c573832bee81959784e5
Version: webpack 2.3.1
Time: 1214ms
     Asset    Size  Chunks                    Chunk Names
    app.js  299 kB       0  [emitted]  [big]  app
app.js.map  368 kB       0  [emitted]         app
   [0] ./main.svl 8.43 kB {0} [built]
   [1] /Users/jp/Documents/Arduino/chickencoop/~/jquery/dist/jquery.js 268 kB {0} [built]
   [2] /Users/jp/Documents/Arduino/chickencoop/~/svelte/shared.js 5.4 kB {0} [built]
   [3] ./app.js 101 bytes {0} [built]

I was mainly just surprised. The code only has one component thus far, so I imagine pulling out shared is actually a loss in this case, but a win once you have multiple components.

Rich-Harris added a commit that referenced this issue Mar 26, 2017
reinstate test, resolve shared path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants