-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shared
should be resolved
#19
Labels
Comments
Related, but not sure if it is the issue: We should probably keep this test to verify the correct |
Webpack output of pre-2.0.0:
And post 2.0.0
I was mainly just surprised. The code only has one component thus far, so I imagine pulling out shared is actually a loss in this case, but a win once you have multiple components. |
Rich-Harris
added a commit
that referenced
this issue
Mar 26, 2017
Rich-Harris
added a commit
that referenced
this issue
Mar 26, 2017
reinstate test, resolve shared path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rollup-plugin-svelte resolves the shared helpers path relative to the plugin itself. that doesn't happen here, and it seems maybe that's resulting in incorrect behaviour somehow?
The text was updated successfully, but these errors were encountered: